Merge lp://qastaging/~charlesk/indicator-datetime/lp-1370594-refresh-notifications-to-match-design into lp://qastaging/indicator-datetime/13.10

Proposed by Charles Kerr
Status: Merged
Approved by: Ted Gould
Approved revision: 380
Merged at revision: 381
Proposed branch: lp://qastaging/~charlesk/indicator-datetime/lp-1370594-refresh-notifications-to-match-design
Merge into: lp://qastaging/indicator-datetime/13.10
Diff against target: 43 lines (+6/-5)
3 files modified
include/notifications/notifications.h (+3/-2)
src/notifications.cpp (+1/-1)
src/snap.cpp (+2/-2)
To merge this branch: bzr merge lp://qastaging/~charlesk/indicator-datetime/lp-1370594-refresh-notifications-to-match-design
Reviewer Review Type Date Requested Status
Nekhelesh Ramananthan (community) Approve
Ted Gould (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+235025@code.qastaging.launchpad.net

Commit message

Make alarm notifications icons and button color match Design's specs.

Description of the change

== Description of the Change

 1. Use the new affirmative-tint hint to color the "OK" button.

 2. Work around unity-notifications bug #1370641 to remove the border around the notification's icon.

I.e., the green button coloring and icon now match design: https://i.imgur.com/Y8SHGnw.png

== Checklist

> Are there any related MPs required for this MP to build/function as expected? Please list.

No

> Is your branch in sync with latest trunk? (e.g. bzr pull lp:trunk -> no changes)

Yes

> Did the code build without warnings?

Yes

> Did the tests run successfully?

Yes

> Did you perform an exploratory manual test run of your code change and any related functionality?

Yes

> If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

N/A

> What device (or emulator) has your component test plan been executed successfully on?

mako + RTM r46

> What manual tests are relevant for this MP?

Run any of the manual tests that involves creating an alarm; e.g. indicator-datetime/snooze, and confirm that the notification's icon and button color look like https://i.imgur.com/Y8SHGnw.png

> Did you include a link to the MR Review Checklist Template to make your reviewer's life easier?

https://wiki.ubuntu.com/Process/Merges/Checklists/indicator-datetime

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ted Gould (ted) :
review: Approve
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Tested on Mako Image 244 and works nicely!

review: Approve
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Please let me confirm with designer tomorrow morning regarding the new visual.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches