Merge lp://qastaging/~charlesk/indicator-datetime/lp-1411171-strengthen-recurrence-rule-test-rtm-14.09 into lp://qastaging/indicator-datetime/rtm-14.09

Proposed by Charles Kerr
Status: Merged
Approved by: Robert Bruce Park
Approved revision: 391
Merged at revision: 391
Proposed branch: lp://qastaging/~charlesk/indicator-datetime/lp-1411171-strengthen-recurrence-rule-test-rtm-14.09
Merge into: lp://qastaging/indicator-datetime/rtm-14.09
Diff against target: 34 lines (+11/-2)
2 files modified
src/engine-eds.cpp (+5/-2)
tests/manual (+6/-0)
To merge this branch: bzr merge lp://qastaging/~charlesk/indicator-datetime/lp-1411171-strengthen-recurrence-rule-test-rtm-14.09
Reviewer Review Type Date Requested Status
dobey (community) Approve
Review via email: mp+246634@code.qastaging.launchpad.net

Commit message

Fix bug that misidentified repeating alarms as one-time alarms, causing them to be disabled after triggering.

Description of the change

Fix bug that misidentified repeating alarms as one-time alarms, causing them to be disabled after triggering.

=== Change Description

Fix bug that misidentified repeating alarms as one-time alarms, causing them to be disabled after triggering.

trunk MP @ https://code.launchpad.net/~charlesk/indicator-datetime/lp-1411171-strengthen-recurrence-rule-test/+merge/246629

=== MP Checklist

> Are there any related MPs required for this MP to build/function as expected? Please list.

No prerequisites

> Is your branch in sync with latest trunk? (e.g. bzr pull lp:trunk -> no changes)

Yes, for latest rtm-14.09

> Did the code build without warnings?

Yes

> Did the tests run successfully?

Yes

> Did you perform an exploratory manual test run of your code change and any related functionality?

Yes

> If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

N/A

> What device (or emulator) has your component test plan been executed successfully on?

Krillin 198

> What manual tests are relevant for this MP?

indicator-datetime/disable-one-time-alarms-after-notification

> Did you include a link to the MR Review Checklist Template to make your reviewer's life easier?

https://wiki.ubuntu.com/Process/Merges/Checklists/indicator-datetime

To post a comment you must log in.
Revision history for this message
dobey (dobey) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches