Merge lp://qastaging/~charlesk/indicator-datetime/lp-1426519-add-tag-for-menuitem-activation-url into lp://qastaging/indicator-datetime/15.10

Proposed by Charles Kerr
Status: Merged
Approved by: Ted Gould
Approved revision: 411
Merged at revision: 412
Proposed branch: lp://qastaging/~charlesk/indicator-datetime/lp-1426519-add-tag-for-menuitem-activation-url
Merge into: lp://qastaging/indicator-datetime/15.10
Diff against target: 246 lines (+175/-5)
5 files modified
src/engine-eds.cpp (+24/-5)
tests/CMakeLists.txt (+1/-0)
tests/test-eds-tasks-config-files/.config/evolution/sources/system-proxy.source (+21/-0)
tests/test-eds-tasks-config-files/.local/share/evolution/tasks/system/tasks.ics (+28/-0)
tests/test-eds-tasks.cpp (+101/-0)
To merge this branch: bzr merge lp://qastaging/~charlesk/indicator-datetime/lp-1426519-add-tag-for-menuitem-activation-url
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+258301@code.qastaging.launchpad.net

Commit message

If the "X-CANONICAL-ACTIVATION-URL" x-prop is defined in the VTODO or VEVENT, use it for url delegation.

Description of the change

Sibling 15.04 MP: https://code.launchpad.net/~charlesk/indicator-datetime/lp-1426519-add-tag-for-menuitem-activation-url/+merge/253997

If the "X-CANONICAL-ACTIVATION-URL" x-prop is defined in the VTODO or VEVENT, use it for url delegation.

Since no clients are using this key yet, a little white-box testing is necessary:

Steps
1. in clock-app, create a repeating alarm
2. $ stop indicator-datetime
3. $ pkill -f evolution-calendar-factory
4. Edit ~/.local/share/evolution/tasks/${some-unique-epoch-id-generated-by-evolution}/tasks.ics:
   After the line "BEGIN:VTODO^M", insert a new line:
   X-CANONICAL-ACTIVATION-URL:http://www.canonical.com/^M
5. $ start indicator-datetime
6. pull down the indicator menu
7. click on the alarm that you edited in step 4

Expected result:
Browser should launch to http://www.canonical.com/

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ted Gould (ted) :
review: Approve
Revision history for this message
Ted Gould (ted) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches