Merge lp://qastaging/~charlesk/indicator-messages/lp-1493534-fix-null-error-dereference into lp://qastaging/indicator-messages
Proposed by
Charles Kerr
| Status: | Approved |
|---|---|
| Approved by: | Antti Kaijanmäki |
| Approved revision: | 449 |
| Proposed branch: | lp://qastaging/~charlesk/indicator-messages/lp-1493534-fix-null-error-dereference |
| Merge into: | lp://qastaging/indicator-messages |
| Diff against target: |
17 lines (+6/-2) 1 file modified
src/im-application-list.c (+6/-2) |
| To merge this branch: | bzr merge lp://qastaging/~charlesk/indicator-messages/lp-1493534-fix-null-error-dereference |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot (community) | continuous-integration | Approve | |
| Antti Kaijanmäki (community) | Approve | ||
| Pete Woods | Pending | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2015-09-09.
Commit message
When parsing the async response of list_sources(), test GError for NULL before dereferencing it
Description of the change
When parsing the async response of list_sources(), test GError for NULL before dereferencing it.
This should've landed awhile back. Queuing it up now for spring cleaning.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Unmerged revisions
- 449. By Charles Kerr
-
fix typo
- 448. By Charles Kerr
-
test the GError for NULL before dereferencing it
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
FAILED: Continuous integration, rev:448
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild:
http://