Merge lp://qastaging/~charlesk/indicator-session/lp-1044015 into lp://qastaging/indicator-session/12.10

Proposed by Charles Kerr
Status: Merged
Approved by: Ted Gould
Approved revision: 355
Merged at revision: 353
Proposed branch: lp://qastaging/~charlesk/indicator-session/lp-1044015
Merge into: lp://qastaging/indicator-session/12.10
Diff against target: 247 lines (+161/-17)
2 files modified
src/indicator-session.c (+158/-16)
src/shared-names.h (+3/-1)
To merge this branch: bzr merge lp://qastaging/~charlesk/indicator-session/lp-1044015
Reviewer Review Type Date Requested Status
jenkins (community) continuous-integration Approve
Ted Gould (community) Approve
Review via email: mp+122179@code.qastaging.launchpad.net

Description of the change

This code is ready for review but I'm marking it "work in progress" because I don't want Tarmac to autoland it before Design has a chance to say what the indicator's a11y text should be here.

To post a comment you must log in.
Revision history for this message
Charles Kerr (charlesk) wrote :

Neither mpt nor JohnLea had an opinion on the error state a11y text, changing from "work in progress" to "ready for review"

Revision history for this message
Ted Gould (ted) :
review: Approve
356. By Charles Kerr

add a11y case for attention needed, but username display disabled

Revision history for this message
jenkins (martin-mrazik+qa) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches