The Sync Menu

Merge lp://qastaging/~charlesk/indicator-sync/lp-1040137 into lp://qastaging/indicator-sync/12.10

  1. lp-1040137
  2. Merge into trunk
Proposed by Charles Kerr
Status: Merged
Approved by: Charles Kerr
Approved revision: 51
Merged at revision: 13
Proposed branch: lp://qastaging/~charlesk/indicator-sync/lp-1040137
Merge into: lp://qastaging/indicator-sync/12.10
Diff against target: 392 lines (+211/-46)
3 files modified
src/service/app-menu-item.c (+4/-4)
src/service/sync-service.c (+25/-24)
test/test-client.cpp (+182/-18)
To merge this branch: bzr merge lp://qastaging/~charlesk/indicator-sync/lp-1040137
Reviewer Review Type Date Requested Status
Lars Karlitski (community) Approve
jenkins (community) continuous-integration Approve
Review via email: mp+121932@code.qastaging.launchpad.net

Description of the change

Re-proposing to trigger Jenkins

To post a comment you must log in.
Revision history for this message
jenkins (martin-mrazik+qa) wrote :

FAILED: Continuous integration, rev:44
http://jenkins.qa.ubuntu.com/job/indicator-sync-ci/3/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-sync-ci/./distribution=quantal,flavor=amd64/3/console

review: Needs Fixing (continuous-integration)
Revision history for this message
jenkins (martin-mrazik+qa) wrote :

FAILED: Continuous integration, rev:46
http://jenkins.qa.ubuntu.com/job/indicator-sync-ci/4/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-sync-ci/./distribution=quantal,flavor=amd64/4/console

review: Needs Fixing (continuous-integration)
Revision history for this message
jenkins (martin-mrazik+qa) wrote :

FAILED: Continuous integration, rev:47
http://jenkins.qa.ubuntu.com/job/indicator-sync-ci/5/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-sync-ci/./distribution=quantal,flavor=amd64/5/console

review: Needs Fixing (continuous-integration)
Revision history for this message
jenkins (martin-mrazik+qa) wrote :

FAILED: Continuous integration, rev:48
http://jenkins.qa.ubuntu.com/job/indicator-sync-ci/7/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-sync-ci/./distribution=quantal,flavor=amd64/7/console

review: Needs Fixing (continuous-integration)
Revision history for this message
jenkins (martin-mrazik+qa) wrote :

FAILED: Continuous integration, rev:49
http://jenkins.qa.ubuntu.com/job/indicator-sync-ci/8/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-sync-ci/./distribution=quantal,flavor=amd64/8/console

review: Needs Fixing (continuous-integration)
Revision history for this message
jenkins (martin-mrazik+qa) wrote :

PASSED: Continuous integration, rev:50
http://jenkins.qa.ubuntu.com/job/indicator-sync-ci/9/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sync-ci/./distribution=quantal,flavor=amd64/9/console

review: Approve (continuous-integration)
Revision history for this message
jenkins (martin-mrazik+qa) wrote :

PASSED: Continuous integration, rev:51
http://jenkins.qa.ubuntu.com/job/indicator-sync-ci/10/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sync-ci/./distribution=quantal,flavor=amd64/10/console

review: Approve (continuous-integration)
Revision history for this message
Lars Karlitski (larsu) wrote :

I'm starting to feel bad about my testing with all those tests your adding to i-sync ;)

I think it would make sense to also test removing a sync client in TestClientCount.

TestState is impressive.

r49 is the best.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: