The Sync Menu

Merge lp://qastaging/~charlesk/indicator-sync/lp-1063003 into lp://qastaging/indicator-sync/13.04

  1. lp-1063003
  2. Merge into trunk.13.04
Proposed by Charles Kerr
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 33
Merged at revision: 32
Proposed branch: lp://qastaging/~charlesk/indicator-sync/lp-1063003
Merge into: lp://qastaging/indicator-sync/13.04
Diff against target: 43 lines (+11/-6)
2 files modified
src/service/app-menu-item.c (+0/-1)
src/service/sync-service.c (+11/-5)
To merge this branch: bzr merge lp://qastaging/~charlesk/indicator-sync/lp-1063003
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Indicator Applet Developers Pending
Review via email: mp+155851@code.qastaging.launchpad.net

Commit message

Fixes bug #1063003 and another minor error uncovered by valgrind while I was testing 1063003's fix.

Description of the change

Same as https://code.launchpad.net/~charlesk/indicator-sync/lp-1063003/+merge/155805, but for 13.04 instead of 13.10

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:33
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~charlesk/indicator-sync/lp-1063003/+merge/155851/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/indicator-sync-13.04-ci/1/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sync-13.04-raring-amd64-ci/1

Click here to trigger a rebuild:
http://s-jenkins:8080/job/indicator-sync-13.04-ci/1/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, I've set a commit message and I'm approving, we want that fix in raring

Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) wrote :

Hm, previously Jenkins knew to use the description as the commit message when the commit message was missing. Looks like that may have broken when the scripts changed over for 13.10, I'll talk to alesage about it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches