The Sync Menu

Merge lp://qastaging/~charlesk/indicator-sync/warn-on-dbus-failure into lp://qastaging/indicator-sync/13.10

  1. warn-on-dbus-failure
  2. Merge into trunk.13.10
Proposed by Charles Kerr
Status: Merged
Approved by: Lars Karlitski
Approved revision: 39
Merged at revision: 38
Proposed branch: lp://qastaging/~charlesk/indicator-sync/warn-on-dbus-failure
Merge into: lp://qastaging/indicator-sync/13.10
Diff against target: 20 lines (+2/-2)
1 file modified
src/service/sync-service.c (+2/-2)
To merge this branch: bzr merge lp://qastaging/~charlesk/indicator-sync/warn-on-dbus-failure
Reviewer Review Type Date Requested Status
Lars Karlitski (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+189185@code.qastaging.launchpad.net

Description of the change

As we discussed on Thursday, in on_bus_got(), demote bus errors from g_error() to g_warning() since we're about to exit anyway.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:39
http://jenkins.qa.ubuntu.com/job/indicator-sync-ci/33/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sync-saucy-amd64-ci/3
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sync-saucy-armhf-ci/3
        deb: http://jenkins.qa.ubuntu.com/job/indicator-sync-saucy-armhf-ci/3/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins:8080/job/indicator-sync-ci/33/rebuild

review: Approve (continuous-integration)
Revision history for this message
Lars Karlitski (larsu) wrote :

Did you leave the second g_error() intentionally?

Revision history for this message
Charles Kerr (charlesk) wrote :

lars, yes. That one could go either way. I decided to leave it as a g_error() in because otherwise the application would continue running without any functionality, so it's better to exit.

Revision history for this message
Lars Karlitski (larsu) wrote :

Makes sense. Thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches