lp://qastaging/~charlesk/keeper/fix-tar-creator-test

Branch merges

Propose for merging

1 branch dependent on this one.

Merged into lp://qastaging/keeper/devel

unity-api-1-bot: Needs Fixing (continuous-integration) on 2016-09-12

Xavi Garcia (community): Approve on 2016-08-24

Diff: 408 lines (+113/-131)

6 files modified

tests/integration/helpers/helpers-test-failure.cpp (+1/-1)
tests/integration/helpers/helpers-test.cc (+2/-2)
tests/unit/tar/tar-creator-libarchive-failure-test.cpp (+12/-10)
tests/unit/tar/tar-creator-test.cpp (+1/-1)
tests/utils/file-utils.cpp (+95/-104)
tests/utils/file-utils.h (+2/-13)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1614658: TarCreatorFixture test fails on error_string.contains(QString::fromUtf8(FATAL_ERROR_MESSAGE))

Medium

In Progress

Link a bug report

Related blueprints

114. By Charles Kerr on 2016-09-12

sync with lp:keeper/devel

113. By Charles Kerr on 2016-08-19

sync with lp:keeper/devel

112. By Charles Kerr on 2016-08-19

we don't care what FileUtils' private method fill_directory_recusively() returns, so change its return type from bool to void

111. By Charles Kerr on 2016-08-19

(copyediting) whitespace in FileUtiles::fillTemporaryDirectory()

110. By Charles Kerr on 2016-08-19

fold file-utils.cpp's two private calculate_checksum() methods into one

109. By Charles Kerr on 2016-08-19

FileUtils::fillTemporaryDirectory() isn't allow to fail, so change its return type from bool to void

108. By Charles Kerr on 2016-08-19

remove unused method FileUtils::createDummyFile()

107. By Charles Kerr on 2016-08-19

in TarCreatorFixture::ArchiveWriteHeaderErrorInCalculateSize, ensure the random sandbox that we're tarring has at least two files because the test expects at least two files (one to inject a libarchive warning on, one to inject a libarchive error)

106. By Charles Kerr on 2016-08-19

in tests/utils give FileUtils::fillTemporaryDirectory() a min-files parameter

105. By Charles Kerr on 2016-08-19

in keeper-tar-create-test, remove a redundant EXPECT() test that generated distracting debug warnings