Merge lp://qastaging/~charlesk/libindicate/lp-1023576 into lp://qastaging/libindicate/12.10

Proposed by Charles Kerr
Status: Merged
Approved by: Charles Kerr
Approved revision: 463
Merged at revision: 461
Proposed branch: lp://qastaging/~charlesk/libindicate/lp-1023576
Merge into: lp://qastaging/libindicate/12.10
Diff against target: 99 lines (+22/-5)
5 files modified
libindicate/listener.c (+1/-1)
libindicate/server.c (+3/-3)
tests/test-indicator-display-half-client.c (+0/-1)
tests/test-indicator-display-half-server.c (+9/-0)
tests/test-indicator-display-server.c (+9/-0)
To merge this branch: bzr merge lp://qastaging/~charlesk/libindicate/lp-1023576
Reviewer Review Type Date Requested Status
Lars Karlitski (community) Approve
Review via email: mp+123091@code.qastaging.launchpad.net

Commit message

Fix a minor error, and a separate minor warning, reported by seb. (LP #1023576)

Description of the change

This is a minor fix, and low priority now that libmessaging-menu is here.

However the string <--> object path bug is an easy fix, and we already have some libindicate leak fixes that can be backported for LTS, so there's no harm in fixing this too.

To post a comment you must log in.
Revision history for this message
Lars Karlitski (larsu) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches