libindicator

Merge lp://qastaging/~charlesk/libindicator/fix-test-sources into lp://qastaging/libindicator/12.10

  1. fix-test-sources
  2. Merge into trunk.12.10
Proposed by Charles Kerr
Status: Merged
Merge reported by: Lars Karlitski
Merged at revision: not available
Proposed branch: lp://qastaging/~charlesk/libindicator/fix-test-sources
Merge into: lp://qastaging/libindicator/12.10
Diff against target: 20 lines (+2/-2)
1 file modified
tests/Makefile.am (+2/-2)
To merge this branch: bzr merge lp://qastaging/~charlesk/libindicator/fix-test-sources
Reviewer Review Type Date Requested Status
Lars Karlitski (community) Approve
Review via email: mp+110882@code.qastaging.launchpad.net

Description of the change

Simple fix to a simple bug -- some of the tests' sources were being incorrectly specified, generating this warning:

> tests/Makefile.am:374: service_version_manager_SOURCES multiply defined in condition TRUE ...
> tests/Makefile.am:317: ... `service_version_manager_SOURCES' previously defined here
> tests/Makefile.am:389: variable `service_version_manager_impolite_SOURCES' is defined but no program or
> tests/Makefile.am:389: library has `service_version_manager_impolite' as canonical name (possible typo)

Which also begs the question of whether or not the tests were actually testing what we thought they were.

Happily, all tests pass even after correcting the SOURCES variablenames.

To post a comment you must log in.
Revision history for this message
Lars Karlitski (larsu) wrote :

Very cool, thank you.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches