libindicator

Merge lp://qastaging/~charlesk/libindicator/indicator-loader-profiles into lp://qastaging/libindicator/13.10

  1. indicator-loader-profiles
  2. Merge into trunk.13.10
Proposed by Charles Kerr
Status: Merged
Approved by: Lars Karlitski
Approved revision: 485
Merged at revision: 483
Proposed branch: lp://qastaging/~charlesk/libindicator/indicator-loader-profiles
Merge into: lp://qastaging/libindicator/13.10
Diff against target: 73 lines (+29/-1)
1 file modified
tools/indicator-loader.c (+29/-1)
To merge this branch: bzr merge lp://qastaging/~charlesk/libindicator/indicator-loader-profiles
Reviewer Review Type Date Requested Status
Lars Karlitski (community) Approve
Review via email: mp+155008@code.qastaging.launchpad.net

Description of the change

Let users specify the indicator-ng profile from the command line s.t. indicator-loader can be used to view & test different form factors.

To post a comment you must log in.
Revision history for this message
Lars Karlitski (larsu) wrote :

Great idea! Patch works and looks great, except that the GError is not set to NULL (line 41 in the diff).

review: Needs Fixing
lp://qastaging/~charlesk/libindicator/indicator-loader-profiles updated
485. By Charles Kerr

init the GError pointer to NULL

Revision history for this message
Charles Kerr (charlesk) wrote :

Oh, how did that even work in the first place? Thanks.

Fixed r485.

Revision history for this message
Lars Karlitski (larsu) wrote :

Thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches