libindicator

Merge lp://qastaging/~charlesk/libindicator/lp-1045372 into lp://qastaging/libindicator/12.10

lp-1045372
Merge into trunk.12.10

Proposed by Charles Kerr on 2012-09-12

Status:

Merged

Approved by:

Lars Karlitski on 2012-09-12

Approved revision:

473

Merged at revision:

471

Proposed branch:

lp://qastaging/~charlesk/libindicator/lp-1045372

Merge into:

lp://qastaging/libindicator/12.10

Diff against target:

287 lines (+66/-103)

4 files modified

libindicator/indicator-object.c (+2/-62)
tests/dummy-indicator-visible.c (+10/-2)
tests/test-loader.c (+13/-11)
tools/indicator-loader.c (+41/-28)

To merge this branch:

bzr merge lp://qastaging/~charlesk/libindicator/lp-1045372

Undecided

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Lars Karlitski (community)		2012-09-12	Approve on 2012-09-12
jenkins (community)	continuous-integration		Approve on 2012-09-12
Review via email: mp+123876@code.qastaging.launchpad.net

Commit message

In libindicator, remove the cloak/decloak code in IndicatorObject to address Bug #1045372.

In indicator-loader, support hiding & re-showing IndicatorObjectEntries by caching their menuitems and using gtk_widget_hide / gtk_widget_show.

In tests/test-loader and tests/dummy-indicator-visible.c, support hiding & re-showing IndicatorObjectEntries by caching their parent widgetry instead of using gtk_widget_destroy().

Description of the change

The cloak/decloak code existed to ensure that the IndicatorObjectEntry's widgets were not destroyed by client code on the "entry-removed" signal. Instead, let's fix the client code to understand that IOEs' visibility can be toggled and re-toggled.

Revision history for this message

jenkins (martin-mrazik+qa) wrote on 2012-09-12:

FAILED: Continuous integration, rev:472
http://jenkins.qa.ubuntu.com/job/libindicator-ci/4/
Executed test runs:
FAILURE: http://jenkins.qa.ubuntu.com/job/libindicator-ci/./label=quantal/4/console

review: Needs Fixing (continuous-integration)

lp://qastaging/~charlesk/libindicator/lp-1045372 updated on 2012-09-12

473. By Charles Kerr on 2012-09-12: In tests/test-loader and tests/dummy-indicator-visible.c, support hiding & re-showing IndicatorObjectEntries by caching their parent widgetry instead of using gtk_widget_destroy()