libindicator

Merge lp://qastaging/~charlesk/libindicator/ng-always-update-entry into lp://qastaging/libindicator/13.10

  1. ng-always-update-entry
  2. Merge into trunk.13.10
Proposed by Charles Kerr
Status: Merged
Approved by: Ted Gould
Approved revision: 498
Merged at revision: 498
Proposed branch: lp://qastaging/~charlesk/libindicator/ng-always-update-entry
Merge into: lp://qastaging/libindicator/13.10
Diff against target: 19 lines (+3/-6)
1 file modified
libindicator/indicator-ng.c (+3/-6)
To merge this branch: bzr merge lp://qastaging/~charlesk/libindicator/ng-always-update-entry
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Ted Gould (community) Approve
Lars Karlitski Pending
Review via email: mp+169922@code.qastaging.launchpad.net

Description of the change

in indicator_ng_update_entry, unconditionally call set_label, set_icon, set_accessible. Previously these were only called if the respective fields weren't NULL, which made it impossible to, for example, turn off a label or icon once it had been set.

To post a comment you must log in.
Revision history for this message
Ted Gould (ted) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:498
http://jenkins.qa.ubuntu.com/job/libindicator-ci/29/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-amd64-ci/16
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-armhf-ci/15

Click here to trigger a rebuild:
http://s-jenkins:8080/job/libindicator-ci/29/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches