Merge lp://qastaging/~chasedouglas/unity/fix-EndDrag into lp://qastaging/unity
Proposed by
Chase Douglas
| Status: | Merged |
|---|---|
| Approved by: | Marco Trevisan (Treviño) |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 2322 |
| Proposed branch: | lp://qastaging/~chasedouglas/unity/fix-EndDrag |
| Merge into: | lp://qastaging/unity |
| Diff against target: |
89 lines (+33/-3) 3 files modified
plugins/unityshell/src/GestureEngine.cpp (+2/-1) tests/test-gesture-engine/compiz_mock/core/screen.h (+10/-2) tests/test-gesture-engine/test_gesture_engine.cpp (+21/-0) |
| To merge this branch: | bzr merge lp://qastaging/~chasedouglas/unity/fix-EndDrag |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Marco Trevisan (Treviño) | Approve | ||
| Alex Launi (community) | quality | Approve | |
|
Review via email:
|
|||
Commit message
Fix potential pointer lockup on initial drag gesture.
Description of the change
GestureEngine: Fix potential pointer lockup on initial drag gesture.
To post a comment you must log in.
Revision history for this message
| Daniel d'Andrada (dandrader) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
On tests/test-
230| drag_data.id = 0;
Might be worth adding a side comment there stating that it's important that the ID is specifically zero.
And/Or commenting on top of that test that it's a regression test for lp bug #979418