GSettings Ubuntu touch schemas

Merge lp://qastaging/~chipaca/gsettings-ubuntu-touch-schemas/fix-notification-hub-blacklist-description into lp://qastaging/gsettings-ubuntu-touch-schemas

  1. fix-notification-hub-blacklist-description
  2. Merge into trunk
Proposed by John Lenton
Status: Approved
Approved by: Sebastien Bacher
Approved revision: 51
Proposed branch: lp://qastaging/~chipaca/gsettings-ubuntu-touch-schemas/fix-notification-hub-blacklist-description
Merge into: lp://qastaging/gsettings-ubuntu-touch-schemas
Diff against target: 15 lines (+3/-2)
1 file modified
schemas/com.ubuntu.notifications.hub.gschema.xml.in.in (+3/-2)
To merge this branch: bzr merge lp://qastaging/~chipaca/gsettings-ubuntu-touch-schemas/fix-notification-hub-blacklist-description
Reviewer Review Type Date Requested Status
Sebastien Bacher (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+238417@code.qastaging.launchpad.net

Commit message

Fixed description for notifications blacklist.

Description of the change

There was an error in the description of the blacklist, which stated that a dpkg-installed app would be listed as (appname, appname) -- that's an error because it's very easy to get an appname that is also a valid click package id; what it should've said is that dpkg apps were listed as ("", appname).

Fixed that.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:50
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~chipaca/gsettings-ubuntu-touch-schemas/fix-notification-hub-blacklist-description/+merge/238417/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/gsettings-ubuntu-touch-schemas-ci/43/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gsettings-ubuntu-touch-schemas-utopic-amd64-ci/23
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gsettings-ubuntu-touch-schemas-utopic-armhf-ci/23
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gsettings-ubuntu-touch-schemas-utopic-i386-ci/23

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gsettings-ubuntu-touch-schemas-ci/43/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Sebastien Bacher (seb128) wrote :

thanks, one nitpick though, the bug example shows the value doesn't include the '.desktop', should it be documented as "basename" rather than "filename" then?

review: Needs Information
Reply
lp://qastaging/~chipaca/gsettings-ubuntu-touch-schemas/fix-notification-hub-blacklist-description updated
51. By John Lenton

clarify the desktop filename more

Revision history for this message
Sebastien Bacher (seb128) wrote :

thanks

review: Approve
Reply

Unmerged revisions

51. By John Lenton

clarify the desktop filename more

50. By John Lenton

Fixed an error in the description of the blacklist entries for legacy apps.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches