Music Lens

Merge lp://qastaging/~chipaca/unity-lens-music/cap-decade-filter into lp://qastaging/unity-lens-music

  1. cap-decade-filter
  2. Merge into trunk
Proposed by John Lenton
Status: Merged
Approved by: Alex Launi
Approved revision: 63
Merged at revision: 61
Proposed branch: lp://qastaging/~chipaca/unity-lens-music/cap-decade-filter
Merge into: lp://qastaging/unity-lens-music
Diff against target: 18 lines (+4/-1)
1 file modified
src/musicstore-filter-parser-decade.vala (+4/-1)
To merge this branch: bzr merge lp://qastaging/~chipaca/unity-lens-music/cap-decade-filter
Reviewer Review Type Date Requested Status
Mikkel Kamstrup Erlandsen (community) Approve
Review via email: mp+77845@code.qastaging.launchpad.net

Description of the change

cap the musicstores' decade filter to supported decades

To post a comment you must log in.
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

 review approve

Looks fine, although I'd suggest modifying it to the simpler expression:

 + start_time = start_time.clamp (1900, 2020)

review: Approve
Revision history for this message
John Lenton (chipaca) wrote :

I don't know vala, and couldn't find where the int methods were documented :)

lp://qastaging/~chipaca/unity-lens-music/cap-decade-filter updated
62. By John Lenton

ooh, clamp. likes.

63. By John Lenton

untabify

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: