Mir

Merge lp://qastaging/~chris.gagnon/mir/enabled-arm-tests into lp://qastaging/mir

Proposed by Chris Gagnon
Status: Rejected
Rejected by: Chris Gagnon
Proposed branch: lp://qastaging/~chris.gagnon/mir/enabled-arm-tests
Merge into: lp://qastaging/mir
Diff against target: 28 lines (+2/-5)
2 files modified
cmake/MirCommon.cmake (+1/-1)
debian/rules (+1/-4)
To merge this branch: bzr merge lp://qastaging/~chris.gagnon/mir/enabled-arm-tests
Reviewer Review Type Date Requested Status
Daniel van Vugt Needs Fixing
PS Jenkins bot (community) continuous-integration Needs Fixing
Robert Carr (community) Needs Information
Alan Griffiths Pending
Review via email: mp+191991@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2013-10-18.

Description of the change

test MP for jenkins, resubmitting this merge because armhf should be enabled in jenkins now

To post a comment you must log in.
Revision history for this message
Chris Gagnon (chris.gagnon) wrote : Posted in a previous version of this proposal

Ignore this MP, I am using it for testing jenkins

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Approve (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote : Posted in a previous version of this proposal

I can't see any logs of Android running tests yet, but expect some to still fail:
https://bugs.launchpad.net/mir/+bugs?field.tag=testsfail

Also linked bug 1203004.

Revision history for this message
Daniel van Vugt (vanvugt) : Posted in a previous version of this proposal
review: Approve
Revision history for this message
Alan Griffiths (alan-griffiths) wrote : Posted in a previous version of this proposal

Hmm, obviously not this MP - but we don't seem to have a armhf CI build anymore. what happened to mir-saucy-armhf-ci?

review: Needs Information
Revision history for this message
Alan Griffiths (alan-griffiths) wrote : Posted in a previous version of this proposal

> Hmm, obviously not this MP - but we don't seem to have a armhf CI build
> anymore. what happened to mir-saucy-armhf-ci?

Ah! We only build armhf when targeting lp:mir...

review: Approve
Revision history for this message
Chris Gagnon (chris.gagnon) wrote : Posted in a previous version of this proposal

I'll update the stack config to build armhf against the dev branch

Revision history for this message
Chris Gagnon (chris.gagnon) wrote : Posted in a previous version of this proposal
Revision history for this message
Chris Gagnon (chris.gagnon) wrote :

I resubmitted this merge proposal so jenkins would rebuild it

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

valgrind seems to be different on arm. Vis:

valgrind: Bad option: --error-exitcode=1 --trace-children=yes
valgrind: Use --help for more information or consult the user manual.

(Not sure why this should be - but running the tests without valgrind would be a step forwards.)

1150. By Chris Gagnon

don't do anything special for ANDROID_BUILD in cmake common

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

There seem to be plenty of failures:

The following tests FAILED:
   4 - acceptance-tests (Failed)
   5 - unit-tests (Failed)
   6 - integration-tests (Failed)
and provide no detailed log of what failed.

However we knew that would happen. I think we need to work on the known causes:
    https://bugs.launchpad.net/mir/+bugs?field.tag=testsfail
before this proposal can ever land.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

OK, I need to give this an official review so it shows up correctly in my dashboard :)

I think Resubmit... at a later date when the Android test failures are resolved. Because it's not really sensible to land this now and then have CI failing all the time.

review: Needs Resubmitting
Revision history for this message
Chris Gagnon (chris.gagnon) wrote :

Valgrind is failing because it's being run in a chroot and doesn't have access to proc

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

And if you run it on a real Android, you'll still get failures. A couple of these:
  https://bugs.launchpad.net/mir/+bugs?field.tag=testsfail
which need to be resolved first. Not all of them; probably just one or two more fixes are needed for Android.

Revision history for this message
Robert Carr (robertcarr) wrote :

In light of the discussion: https://code.launchpad.net/~chris.gagnon/mir/development-branch-disable-trace-children-android/+merge/192391

What about enabling android CI without valgrind at first. It's certainly better than what we have running now ;)

review: Needs Information
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

As of just today, I think Android CI might actually be able to pass the automated tests. Can you please resubmit or ping Jenkins?

review: Needs Resubmitting
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

The real fix for bug 1247718 is landing soon. So when it does, this might start passing :)

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Is this branch still required? I think we landed an alternative recently... ?

If so then needs fixing:
Text conflict in debian/rules
1 conflicts encountered.

review: Needs Fixing
Revision history for this message
Chris Gagnon (chris.gagnon) wrote :

a different branch was landed marking as rejected

Unmerged revisions

1150. By Chris Gagnon

don't do anything special for ANDROID_BUILD in cmake common

1149. By Chris Gagnon

update debian rules

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches