Merge into trunk : barebones-autopilot-emulator-for-updates-page : Code : ubuntu-system-settings

Status:	Work in progress
Proposed branch:	lp://qastaging/~chris.gagnon/ubuntu-system-settings/barebones-autopilot-emulator-for-updates-page
Merge into:	lp://qastaging/ubuntu-system-settings
Diff against target:	444 lines (+224/-73) 5 files modified plugins/system-update/PageComponent.qml (+2/-0) tests/autopilot/ubuntu_system_settings/emulators.py (+155/-0) tests/autopilot/ubuntu_system_settings/tests/__init__.py (+61/-58) tests/autopilot/ubuntu_system_settings/tests/test_about.py (+0/-1) tests/autopilot/ubuntu_system_settings/tests/test_system_updates.py (+6/-14)
To merge this branch:	bzr merge lp://qastaging/~chris.gagnon/ubuntu-system-settings/barebones-autopilot-emulator-for-updates-page
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Sebastien Bacher (community)		2014-03-08	Needs Fixing on 2014-05-13
PS Jenkins bot	continuous-integration		Approve on 2014-03-08
Review via email: mp+210036@code.qastaging.launchpad.net

Commit message

barebones emulator for system updates page, add objectNames that were needed for testing

Description of the change

I am trying to use the updates page in the system settings app to do upgrade testing for images that have not been released.

We use a custom proxy object/autopilot emulator in the autopilot tests so all projects can reuse the custom proxy objects.

This will be used to save time when there are changes made to the system-settings app, as we will not have also make changes to all the tests that might check or use something in system-settings with autopilot.

To test the changes there should be an in memory backend that changes the state of the updates page.

There should also be a mock update that does not reboot the phone.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-03-08:

#

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/685/rebuild

review: Approve (continuous-integration)

Reply

Revision history for this message

Sebastien Bacher (seb128) wrote on 2014-03-10:

#

Thank you for the work, I've no reviewed it yet but could you write a short summary of the intend of those changes? What issues are you trying to resolve? How do you recommend testing the changes?

review: Needs Information

Reply

Revision history for this message

Chris Gagnon (chris.gagnon) wrote on 2014-03-10:

#

I am trying to use the updates page in the system settings app to do upgrade testing for images that have not been released.

We use a custom proxy object/autopilot emulator in the autopilot tests so all projects can reuse the custom proxy objects.

This will be used to save time when there are changes made to the system-settings app, as we will not have also make changes to all the tests that might check or use something in system-settings with autopilot.

To test the changes there should be an in memory backend that changes the state of the updates page.

There should also be a mock update that does not reboot the phone.

Reply

Revision history for this message

Sebastien Bacher (seb128) wrote on 2014-05-13:

#

> To test the changes there should be an in memory backend that changes the state of the updates page.
> There should also be a mock update that does not reboot the phone.

Those are not done there though, so it means the current changes should be tested by just checking that tests keep being green with the update?

Some extra changes landed to trunk since you submitted that work and they create conflicts, could you rebase on trunk?

review: Needs Fixing

Reply

Revision history for this message

Sebastien Bacher (seb128) wrote on 2014-06-03:

#

setting to "work in progress", change it back to "needs review" when the issue pointed before are resolved

Reply

Unmerged revisions

641. By Chris Gagnon on 2014-03-08: barebones start on emulator for system-settings
640. By Chris Gagnon on 2014-03-06: add objectNames, create emulator for system updates

ubuntu-system-settings

Merge lp://qastaging/~chris.gagnon/ubuntu-system-settings/barebones-autopilot-emulator-for-updates-page into lp://qastaging/ubuntu-system-settings

Commit message

Description of the change

Unmerged revisions

Preview Diff

Subscribers