Ubuntu UI Toolkit

Merge lp://qastaging/~chris.gagnon/ubuntu-ui-toolkit/fix-bug-1388896 into lp://qastaging/ubuntu-ui-toolkit/staging

  1. fix-bug-1388896
  2. Merge into staging
Proposed by Chris Gagnon
Status: Merged
Approved by: Tim Peeters
Approved revision: 1123
Merged at revision: 1313
Proposed branch: lp://qastaging/~chris.gagnon/ubuntu-ui-toolkit/fix-bug-1388896
Merge into: lp://qastaging/ubuntu-ui-toolkit/staging
Diff against target: 13 lines (+3/-2)
1 file modified
tests/autopilot/ubuntuuitoolkit/tests/gallery/test_textinput.py (+3/-2)
To merge this branch: bzr merge lp://qastaging/~chris.gagnon/ubuntu-ui-toolkit/fix-bug-1388896
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Tim Peeters Approve
Leo Arias (community) code review Approve
Review via email: mp+240496@code.qastaging.launchpad.net

Commit message

fix compare string in ubuntuuitoolkit.tests.gallery.test_textinput.DisabledTextInputTestCase

Description of the change

fix compare string in ubuntuuitoolkit.tests.gallery.test_textinput.DisabledTextInputTestCase

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1121
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1194/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/6418
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-amd64-ci/1027
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/1026
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/1026/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-i386-ci/1026
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/6022
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7670
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7670/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/15369

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1194/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Leo Arias (elopio) wrote :

It passes on CI, so it looks good. But if fails for me on vivid because the textfield doesn't have the text.

review: Needs Information
Revision history for this message
Chris Gagnon (chris.gagnon) wrote :

So I'll have to add a helper to get the version from lsb_release -a and have 2 asserts... 1 for < 15.04 and one for > 14.10

Where do you think the helper should go? Upstream in autopilot or in the uitoolkit?

I am thinking autopilot.

lp://qastaging/~chris.gagnon/ubuntu-ui-toolkit/fix-bug-1388896 updated
1122. By Chris Gagnon

fix test so it passes in vivid

Revision history for this message
Chris Gagnon (chris.gagnon) wrote :

I found a standard lib that gives me the release info platform.dist() no need for a helper

lp://qastaging/~chris.gagnon/ubuntu-ui-toolkit/fix-bug-1388896 updated
1123. By Chris Gagnon

use generic solution, don't rely on distro version

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1122
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1198/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/6431
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-amd64-ci/1031
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/1030
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/1030/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-i386-ci/1030
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/6033
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7683
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7683/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/15383

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1198/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Leo Arias (elopio) wrote :

I like this last solution. Thanks Chris for working on this.
I would still like to know why this failure went unnoticed. And why the gallery behaves differently for me on vivid. Lets use the bug reported for that discussion.

review: Approve (code review)
Revision history for this message
Tim Peeters (tpeeters) wrote :

These changes make no sense for me. The user should not be able to type in a disabled textfield, so after typing, its contents must not be changed to the typed string.

review: Needs Resubmitting
Revision history for this message
Tim Peeters (tpeeters) wrote :

^ I didn't mean to set the review to "Resubmit" above. Launchpad is broken for me and I cannot change the status

Revision history for this message
Tim Peeters (tpeeters) wrote :

Sorry for the "status mess". Popups in Chromium appear broken when I have hidpi support enabled. It works fine now in Firefox.

review: Needs Fixing
Revision history for this message
Chris Gagnon (chris.gagnon) wrote :

that is what I am checking:

1. get the text property from textfield_disabled
2. type in the text field
3. verify text is still the same from step 1

Revision history for this message
Tim Peeters (tpeeters) wrote :

Sorry, it does make sense.

But why is disabled_text not equal to ''? What is its value?

review: Needs Information
Revision history for this message
Tim Peeters (tpeeters) wrote :

It seems to have been broken in r1290 of our staging: http://bazaar.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/staging/revision/1290

The fix looks good now.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1123
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1199/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/6434
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-amd64-ci/1032
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/1031
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-armhf-ci/1031/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-utopic-i386-ci/1031
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/6036
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7686
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7686/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/15386

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1199/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches