DBus Menu

Merge lp://qastaging/~chrisccoulson/libdbusmenu/lp720895 into lp://qastaging/libdbusmenu/0.5

  1. lp720895
  2. Merge into trunk
Proposed by Chris Coulson
Status: Merged
Approved by: Ted Gould
Approved revision: 241
Merged at revision: 248
Proposed branch: lp://qastaging/~chrisccoulson/libdbusmenu/lp720895
Merge into: lp://qastaging/libdbusmenu/0.5
Diff against target: 11 lines (+1/-0)
1 file modified
libdbusmenu-gtk/menuitem.c (+1/-0)
To merge this branch: bzr merge lp://qastaging/~chrisccoulson/libdbusmenu/lp720895
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
Review via email: mp+51594@code.qastaging.launchpad.net

Description of the change

Check the return value of gdk_keyval_name, as passing NULL pointers
to g_variant_builder_add can cause bad things to happen. Might fix LP: #720895

To post a comment you must log in.
Revision history for this message
Ted Gould (ted) wrote :

I moved the keyname check to before the builder is initialized to avoid a possible leak with the builder there. Otherwise all good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches