unity-2d

Merge lp://qastaging/~chrisccoulson/unity-2d/lp1010466 into lp://qastaging/unity-2d

lp1010466
Merge into trunk

Proposed by Chris Coulson on 2012-06-13

Status:

Merged

Approved by:

Gerry Boland on 2012-06-13

Approved revision:

1119

Merged at revision:

1119

Proposed branch:

lp://qastaging/~chrisccoulson/unity-2d/lp1010466

Merge into:

lp://qastaging/unity-2d

Diff against target:

12 lines (+1/-2)

1 file modified

panel/applets/appname/windowhelper.cpp (+1/-2)

To merge this branch:

bzr merge lp://qastaging/~chrisccoulson/unity-2d/lp1010466

High

Fix Committed

Link a bug report

Reviewer	Review Type	Date Requested	Status
Gerry Boland (community)		2012-06-13	Approve on 2012-06-13
jenkins (community)	continuous-integration		Approve on 2012-06-13
Review via email: mp+110075@code.qastaging.launchpad.net

Commit message

[panel] Use the correct event timestamp when closing an application window

Description of the change

[panel] Use the correct event timestamp when closing an application window

Revision history for this message

Gerry Boland (gerboland) wrote on 2012-06-13:

Hi Chris,
the other time we use wnck_window_close, we use "CurrentTime" as the timestamp. Would using this fix the issue also or not?
Thanks
-Gerry

Revision history for this message

jenkins (martin-mrazik+qa) wrote on 2012-06-13:

PASSED: Continuous integration, rev:1119
http://s-jenkins:8080/job/unity-2d-ci/12/

review: Approve (continuous-integration)

Revision history for this message

Chris Coulson (chrisccoulson) wrote on 2012-06-13:

Using CurrentTime would fix this case too, but it's usually more correct to use the timestamp of the event which triggers the action. I don't mind either way though

Revision history for this message

Gerry Boland (gerboland) wrote on 2012-06-13:

TBH I'm not that pushed either. I'm not fond of CurrentTime=0. I'll accept this as is, thank you!

review: Approve