Notify OSD

Merge lp://qastaging/~cimi/notify-osd/color-tweaks into lp://qastaging/~canonical-dx-team/notify-osd/precise

  1. color-tweaks
  2. Merge into precise
Proposed by Andrea Cimitan
Status: Merged
Approved by: Allan LeSage
Approved revision: 458
Merged at revision: 458
Proposed branch: lp://qastaging/~cimi/notify-osd/color-tweaks
Merge into: lp://qastaging/~canonical-dx-team/notify-osd/precise
Diff against target: 59 lines (+24/-7)
1 file modified
src/bubble.c (+24/-7)
To merge this branch: bzr merge lp://qastaging/~cimi/notify-osd/color-tweaks
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
jenkins (community) continuous-integration Approve
John Lea (community) design Approve
Mirco Müller (community) Needs Information
Review via email: mp+100406@code.qastaging.launchpad.net

Description of the change

Add some color tweak capabilities, and slightly start tweaking colors

To post a comment you must log in.
Revision history for this message
Mirco Müller (macslow) wrote :

What design-guideline (bug) requires this change?

review: Needs Information
Revision history for this message
Andrea Cimitan (cimi) wrote :

There's no bug, but you got the mail from John Lea. The goal is to make the color more vibrant and darker trying to mimic the overlay blending used in the dash but using over as operator.

Revision history for this message
Mirco Müller (macslow) wrote :

I would rather review this again, when the BGHash change (from Gord) is available... which is sometime later today then.

Revision history for this message
Andrea Cimitan (cimi) wrote :

up! :-)

Revision history for this message
John Lea (johnlea) wrote :

Signed off by design

review: Approve (design)
Revision history for this message
jenkins (martin-mrazik+qa) wrote :

PASSED: Continuous integration, rev:458
http://s-jenkins:8080/job/notify-osd-ci/2/

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:458
http://jenkins.qa.ubuntu.com/job/notify-osd-ci/6/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notify-osd-ci/./build=pbuilder,distribution=quantal,flavor=amd64/6/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notify-osd-ci/./build=pbuilder,distribution=quantal,flavor=i386/6/console

review: Approve (continuous-integration)
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

was never approved, approving.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/notify-osd-autolanding/2/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/notify-osd-autolanding/./build=pbuilder,distribution=quantal,flavor=amd64/2/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/notify-osd-autolanding/./build=pbuilder,distribution=quantal,flavor=i386/2/console

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
Approved revid is not set in launchpad (maybe a permission problem?).
http://jenkins.qa.ubuntu.com/job/notify-osd-autolanding/4/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notify-osd-autolanding/./build=pbuilder,distribution=quantal,flavor=amd64/4/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notify-osd-autolanding/./build=pbuilder,distribution=quantal,flavor=armhf/4/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notify-osd-autolanding/./build=pbuilder,distribution=quantal,flavor=i386/4/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notify-osd-autolanding/./build=pbuilder,distribution=raring,flavor=amd64/4/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notify-osd-autolanding/./build=pbuilder,distribution=raring,flavor=armhf/4/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notify-osd-autolanding/./build=pbuilder,distribution=raring,flavor=i386/4/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Allan LeSage (allanlesage) wrote :

Apologies on Jenkins' behalf for the mess--the code should land with this new approval. (Was caught expecting inline packaging to land and had to adjust.)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches