Notify OSD

Merge lp://qastaging/~cimi/notify-osd/no-deprecated-functions into lp://qastaging/~canonical-dx-team/notify-osd/precise

no-deprecated-functions
Merge into precise

Proposed by Andrea Cimitan on 2012-04-02

Status:	Needs review
Proposed branch:	lp://qastaging/~cimi/notify-osd/no-deprecated-functions
Merge into:	lp://qastaging/~canonical-dx-team/notify-osd/precise
Diff against target:	136 lines (+36/-16) 5 files modified egg/egg-timeout-pool.c (+7/-8) src/bubble.c (+8/-1) src/defaults.c (+5/-5) tests/test-grow-bubble.c (+8/-1) tests/test-scroll-text.c (+8/-1)
To merge this branch:	bzr merge lp://qastaging/~cimi/notify-osd/no-deprecated-functions
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot (community)	continuous-integration		Approve on 2012-10-15
jenkins (community)	continuous-integration		Approve on 2012-06-25
Mirco Müller (community)		2012-04-02	Needs Fixing on 2012-04-04
Review via email: mp+100412@code.qastaging.launchpad.net

Description of the change

Use the proper not-deprecated functions.

Please make sure egg_timeout_pool_get_ticks is returning the difference with the required scale, since I didn't pay much attention in the right conversion.

Revision history for this message

Mirco Müller (macslow) wrote on 2012-04-04:

Your branch is breaking the timing calculations. Very obvious e.g. in the much too short throbbing animation of the volume over- and undershoot animations.

review: Needs Fixing

Revision history for this message

Andrea Cimitan (cimi) wrote on 2012-04-04:

Exactly as I said in the description: egg_timeout_pool_get_ticks needs the right scale, could you please help me on that? I will multiply the value returned by the function.