Merge lp://qastaging/~cimi/unity/render-frame-on-panel into lp://qastaging/unity
Proposed by
Andrea Cimitan
| Status: | Merged |
|---|---|
| Approved by: | Mirco Müller |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 1517 |
| Proposed branch: | lp://qastaging/~cimi/unity/render-frame-on-panel |
| Merge into: | lp://qastaging/unity |
| Prerequisite: | lp://qastaging/~njpatel/unity/fix-panel-opacity |
| Diff against target: |
10 lines (+1/-0) 1 file modified
plugins/unityshell/src/PanelStyle.cpp (+1/-0) |
| To merge this branch: | bzr merge lp://qastaging/~cimi/unity/render-frame-on-panel |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Mirco Müller (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
The unity panel just render the background, but I think it might be nice also to render a frame around it.
That could be useful to draw a subtle highlight at the top (like it is now, but with a workaround in the gradient), or borders of any kind (like gnome shell too, if anyone is interested).
Please note that even if this code will request one more call to the theming engine but:
1) in case of Ambiance and Radiance nothing will change in the look so can't be seen as an UIFe (cause they are both using border-width: 0; in their css, so the theming engine loads render frame but it returns after a few checks)
2) considering the low number of requests to redraw the panel, it is not affecting performance at all.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Approved.