Unity 8

Merge lp://qastaging/~cimi/unity8/unity8.audioPreview_buffer into lp://qastaging/unity8

  1. unity8.audioPreview_buffer
  2. Merge into trunk
Proposed by Andrea Cimitan
Status: Work in progress
Proposed branch: lp://qastaging/~cimi/unity8/unity8.audioPreview_buffer
Merge into: lp://qastaging/unity8
Diff against target: 43 lines (+15/-3)
1 file modified
qml/Dash/Previews/PreviewAudioPlayback.qml (+15/-3)
To merge this branch: bzr merge lp://qastaging/~cimi/unity8/unity8.audioPreview_buffer
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Unity Team Pending
Review via email: mp+217678@code.qastaging.launchpad.net

Commit message

Added buffer progressbar for the AudioPlayback preview widget, but not testing it because it requires real audio files in order for it to display

Description of the change

on hold for https://bugreports.qt-project.org/browse/QTBUG-38688 and https://bugreports.qt.io/browse/QTBUG-38944

* Are there any related MPs required for this MP to build/function as expected? Please list.
No
 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
 * Did you make sure that your branch does not contain spurious tags?
Yes
 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
lp://qastaging/~cimi/unity8/unity8.audioPreview_buffer updated
859. By Andrea Cimitan

Small refactoring

860. By Andrea Cimitan

Less computation

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:859
http://jenkins.qa.ubuntu.com/job/unity8-ci/2884/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-trusty-touch/502
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1748
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/1405
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1409
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1409/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/1405
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/444
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/4766
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/4766/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/6519

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2884/rebuild

review: Needs Fixing (continuous-integration)
Reply

Unmerged revisions

860. By Andrea Cimitan

Less computation

859. By Andrea Cimitan

Small refactoring

858. By Andrea Cimitan

Not in this branch

857. By Andrea Cimitan

Not testing buffering because it requires real audio to work

856. By Andrea Cimitan

Add preview audio playback progressbar buffer

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches