Merge lp://qastaging/~cjcurran/indicator-sound/mpris-interface-name-translation-fix into lp://qastaging/indicator-sound/sound-menu-v2
Proposed by
Conor Curran
| Status: | Merged |
|---|---|
| Merged at revision: | 149 |
| Proposed branch: | lp://qastaging/~cjcurran/indicator-sound/mpris-interface-name-translation-fix |
| Merge into: | lp://qastaging/indicator-sound/sound-menu-v2 |
| Diff against target: |
71 lines (+8/-3) 3 files modified
src/mpris2-controller.vala (+3/-3) src/music-player-bridge.vala (+2/-0) src/player-controller.vala (+3/-0) |
| To merge this branch: | bzr merge lp://qastaging/~cjcurran/indicator-sound/mpris-interface-name-translation-fix |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| David Barth | Approve | ||
|
Review via email:
|
|||
Description of the change
Fixes the regression causes by the initial fix for this bug ->
https:/
"Omer: Yes, I did and also reboot. Please note that if you didn't have the translated text problem, this new problem also probably doesn't affect you. It's now certainly something that used to use the application name "Rhythmbox" to send the signals, but now that the translated name is used the control signals no more go through (since they should probably still be sent with the original application name instead of the translated name)."
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM