Merge lp://qastaging/~cjcurran/indicator-sound/service-crash-unresponsive-dbus-client into lp://qastaging/indicator-sound/sound-menu-v2
Proposed by
Conor Curran
| Status: | Merged |
|---|---|
| Merged at revision: | 135 |
| Proposed branch: | lp://qastaging/~cjcurran/indicator-sound/service-crash-unresponsive-dbus-client |
| Merge into: | lp://qastaging/indicator-sound/sound-menu-v2 |
| Diff against target: |
349 lines (+95/-60) 7 files modified
src/dbus-menu-manager.c (+4/-3) src/indicator-sound.c (+55/-35) src/mpris2-controller.vala (+10/-12) src/pulse-manager.c (+4/-6) src/slider-menu-item.c (+1/-2) src/volume-widget.c (+19/-2) src/volume-widget.h (+2/-0) |
| To merge this branch: | bzr merge lp://qastaging/~cjcurran/indicator-sound/service-crash-unresponsive-dbus-client |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Cody Russell (community) | Approve | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2010-09-14.
Description of the change
- makes sure all mpris dbus method calls are async
- in the case of a service crash the indicator should reset itself properly and populate like normal from the restarted service.
To post a comment you must log in.
Revision history for this message
| Cody Russell (bratsche) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
