The Sound Menu

Merge lp://qastaging/~cjcurran/indicator-sound/sigabrt into lp://qastaging/~indicator-applet-developers/indicator-sound/trunk_3

  1. sigabrt
  2. Merge into trunk_3
Proposed by Conor Curran
Status: Merged
Merged at revision: 234
Proposed branch: lp://qastaging/~cjcurran/indicator-sound/sigabrt
Merge into: lp://qastaging/~indicator-applet-developers/indicator-sound/trunk_3
Diff against target: 27 lines (+8/-2)
1 file modified
src/sound-service-dbus.c (+8/-2)
To merge this branch: bzr merge lp://qastaging/~cjcurran/indicator-sound/sigabrt
Reviewer Review Type Date Requested Status
Mikkel Kamstrup Erlandsen (community) Approve
Review via email: mp+54848@code.qastaging.launchpad.net

Description of the change

Fixes the bug attached.

To post a comment you must log in.
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

8 + if (priv->connection == NULL ||
9 + g_dbus_connection_is_closed (priv->connection) == TRUE){
10 + g_critical ("sound_service_dbus_update_sound_state - connection no good !!");
11 + return;
12 + }
13 +

If this occurs I think it's crucial for debugging to know which one of the two conditions happened?

Maybe like this instead:

+ if (priv->connection == NULL || g_dbus_connection_is_closed (priv->connection)) {
+ g_critical ("sound_service_dbus_update_sound_state - connection is %s !!",
+ connection == NULL? "NULL" : "closed");
+ return;
+ }

But no biggie. Approved.

review: Approve
Revision history for this message
Conor Curran (cjcurran) wrote :

Makes sense, applying to the merge.

lp://qastaging/~cjcurran/indicator-sound/sigabrt updated
237. By Conor Curran

more visibility on possible errors

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches