Merge lp://qastaging/~cjohnston/launchpad-work-items-tracker/no-crash-on-404 into lp://qastaging/launchpad-work-items-tracker
Proposed by
Chris Johnston
| Status: | Merged |
|---|---|
| Approved by: | Martin Pitt |
| Approved revision: | 310 |
| Merged at revision: | 311 |
| Proposed branch: | lp://qastaging/~cjohnston/launchpad-work-items-tracker/no-crash-on-404 |
| Merge into: | lp://qastaging/launchpad-work-items-tracker |
| Diff against target: |
36 lines (+10/-2) 1 file modified
lpworkitems/collect.py (+10/-2) |
| To merge this branch: | bzr merge lp://qastaging/~cjohnston/launchpad-work-items-tracker/no-crash-on-404 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Martin Pitt (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
The collect script will error and give a traceback when a 404 is received from the LP API. This allow the script to continue after getting a 404.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This is a crash that "Should Not Happen"™. Can you find out the URL that crashes and report a bug against Launchpad for this?
As a workaround this looks good to me, thanks!