Ubuntu CI Dashboard

Merge lp://qastaging/~cjohnston/qa-dashboard/breakdown-settings into lp://qastaging/qa-dashboard

  1. breakdown-settings
  2. Merge into dev
Proposed by Chris Johnston
Status: Merged
Approved by: Chris Johnston
Approved revision: 672
Merged at revision: 671
Proposed branch: lp://qastaging/~cjohnston/qa-dashboard/breakdown-settings
Merge into: lp://qastaging/qa-dashboard
Diff against target: 150 lines (+98/-12)
4 files modified
common/tests/__init__.py (+1/-0)
common/tests/test_settings.py (+82/-0)
local_settings.py.example (+0/-11)
qa_dashboard/settings.py (+15/-1)
To merge this branch: bzr merge lp://qastaging/~cjohnston/qa-dashboard/breakdown-settings
Reviewer Review Type Date Requested Status
Joe Talbott Approve
PS Jenkins bot continuous-integration Approve
Andy Doan (community) Approve
Review via email: mp+193284@code.qastaging.launchpad.net

Commit message

Provide the ability to split db and amqp settings out into their own settings files

Description of the change

During the process of charming the dashboard, I have found that I believe the charm would work better if the db and oops settings were broken out from local_settings and placed into their own files. This should make it easier for the charm to update any of this data.

To post a comment you must log in.
lp://qastaging/~cjohnston/qa-dashboard/breakdown-settings updated
670. By Chris Johnston

[r=Andy Doan, PS Jenkins bot] Removing sf4p from kpi per ev 1246125 from Chris Johnston

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:670
http://10.97.0.26:8080/job/dashboard-ci/242/
Executed test runs:

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/dashboard-ci/242/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andy Doan (doanac) wrote :

tested with my local settings and it still seemed to work

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:671
http://10.97.0.26:8080/job/dashboard-ci/243/
Executed test runs:

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/dashboard-ci/243/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:672
http://10.97.0.26:8080/job/dashboard-ci/244/
Executed test runs:

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/dashboard-ci/244/rebuild

review: Approve (continuous-integration)
lp://qastaging/~cjohnston/qa-dashboard/breakdown-settings updated
671. By Chris Johnston

Add tests

672. By Chris Johnston

Update tests per review

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:672
http://10.97.0.26:8080/job/dashboard-ci/245/
Executed test runs:

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/dashboard-ci/245/rebuild

review: Approve (continuous-integration)
Revision history for this message
Joe Talbott (joetalbott) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches