Merge lp://qastaging/~cjohnston/qa-dashboard/d-t2-orderable into lp://qastaging/qa-dashboard

Proposed by Chris Johnston
Status: Merged
Approved by: Chris Johnston
Approved revision: 593
Merged at revision: 594
Proposed branch: lp://qastaging/~cjohnston/qa-dashboard/d-t2-orderable
Merge into: lp://qastaging/qa-dashboard
Diff against target: 39 lines (+5/-5)
1 file modified
memory/tables.py (+5/-5)
To merge this branch: bzr merge lp://qastaging/~cjohnston/qa-dashboard/d-t2-orderable
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Andy Doan (community) Approve
Review via email: mp+183765@code.qastaging.launchpad.net

Commit message

Switch to using orderable instead of sortable for django-tables2

Description of the change

From the django-tables2 changelog:

Deprecated BoundColumn.sortable, Column.sortable, Table.sortable, sortable CSS class, BoundColumns.itersortable, BoundColumns.sortable; use orderable instead of sortable.

With Django 1.5 deprecation warnings start. Switching now to begin preparing for Django 1.5

To post a comment you must log in.
Revision history for this message
Andy Doan (doanac) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:593
http://s-jenkins:8080/job/dashboard-ci/170/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins:8080/job/dashboard-ci/170/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:593
http://s-jenkins:8080/job/dashboard-ci/171/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins:8080/job/dashboard-ci/171/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches