Ubuntu CI Dashboard

Merge lp://qastaging/~cjohnston/qa-dashboard/performance-models-max-length into lp://qastaging/qa-dashboard

  1. performance-models-max-length
  2. Merge into dev
Proposed by Chris Johnston
Status: Merged
Approved by: Chris Johnston
Approved revision: 647
Merged at revision: 654
Proposed branch: lp://qastaging/~cjohnston/qa-dashboard/performance-models-max-length
Merge into: lp://qastaging/qa-dashboard
Diff against target: 1191 lines (+984/-32)
9 files modified
eventstat/migrations/0004_increase_max_length.py (+260/-0)
eventstat/models.py (+12/-12)
idle_power/migrations/0005_increase_max_length.py (+141/-0)
memevent/migrations/0007_increase_max_length.py (+135/-0)
memory/migrations/0004_increase_max_length.py (+290/-0)
memory/models.py (+6/-6)
performance/models.py (+13/-10)
power/migrations/0007_increase_max_length.py (+123/-0)
power/models.py (+4/-4)
To merge this branch: bzr merge lp://qastaging/~cjohnston/qa-dashboard/performance-models-max-length
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Joe Talbott Approve
Review via email: mp+192163@code.qastaging.launchpad.net

Commit message

Increase performance based models max_length's

To post a comment you must log in.
Revision history for this message
Joe Talbott (joetalbott) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:647
http://10.97.0.26:8080/job/dashboard-ci/219/
Executed test runs:

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/dashboard-ci/219/rebuild

review: Approve (continuous-integration)
Revision history for this message
Paul Larson (pwlars) wrote :

ISTR reading somwhere that using charfield with max_length was no more efficient, and in some cases less efficient, than just using textfield. Especially since your max_length is so large, wouldn't it be better to just move to textfield and be done with it?

Revision history for this message
Joe Talbott (joetalbott) wrote :

It's worth investigating.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches