Merge lp://qastaging/~cjohnston/qa-dashboard/rel-path into lp://qastaging/qa-dashboard

Proposed by Chris Johnston
Status: Merged
Approved by: Chris Johnston
Approved revision: 689
Merged at revision: 690
Proposed branch: lp://qastaging/~cjohnston/qa-dashboard/rel-path
Merge into: lp://qastaging/qa-dashboard
Diff against target: 168 lines (+21/-34)
3 files modified
common/static/css/jquery.dataTables.css (+11/-23)
common/static/css/new-style.css (+2/-3)
common/static/css/style.css (+8/-8)
To merge this branch: bzr merge lp://qastaging/~cjohnston/qa-dashboard/rel-path
Reviewer Review Type Date Requested Status
Andy Doan (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+197369@code.qastaging.launchpad.net

Commit message

Switch assets to using rel-path

Description of the change

Dashboard plan for charming:

- Add all assets back to lp:qa-dashboard
- Create 'assets' branch for the web team to use to include in assets.u.c (lp:qa-dashboard/assets)
- Create a script to automatically copy staticfiles from lp:qa-dashboard to lp:qa-dashboard/assets when there is an update to assets
- Switch the dashboard to use assets.ubuntu.com for static assets
  * this is the reason for the change in paths in this MP. making the paths relative will cause the site to use the proper assets

Since the assets will be versioned, I will be adding the ability to the script above to update what revision the site needs to look for in assets.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:689
http://s-jenkins.ubuntu-ci:8080/job/dashboard-ci/263/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dashboard-ci/263/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andy Doan (doanac) wrote :

can you elaborate a little? ie - I think you are doing this because you just moved the assets back into our code-base in plans for a new way to use assets.ubuntu.com. However, maybe sharing the whole plan up-front will allow us to understand if each MP makes sense.

Revision history for this message
Andy Doan (doanac) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches