Indicator Date and Time

Merge lp://qastaging/~cjwatson/indicator-datetime/cleanup-timezone-monitor into lp://qastaging/indicator-datetime/13.04

  1. cleanup-timezone-monitor
  2. Merge into trunk.13.04
Proposed by Colin Watson
Status: Merged
Approved by: Mathieu Trudel-Lapierre
Approved revision: 204
Merged at revision: 206
Proposed branch: lp://qastaging/~cjwatson/indicator-datetime/cleanup-timezone-monitor
Merge into: lp://qastaging/indicator-datetime/13.04
Diff against target: 10 lines (+1/-0)
1 file modified
src/datetime-service.c (+1/-0)
To merge this branch: bzr merge lp://qastaging/~cjwatson/indicator-datetime/cleanup-timezone-monitor
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+145921@code.qastaging.launchpad.net

Commit message

Fix timezonefile reference leak in build_timezone.

Description of the change

Fix timezonefile reference leak in build_timezone.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:204
http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/33/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/./build=pbuilder,distribution=coverity-raring,flavor=amd64/33/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/./build=pbuilder,distribution=raring,flavor=armhf/33/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/./build=pbuilder,distribution=raring,flavor=i386/33/console
Coverity artifacts:
    http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/./build=pbuilder,distribution=coverity-raring,flavor=amd64/33//artifact/results/coverity/NO_COVERITY_DEFECTS.txt
    http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/./build=pbuilder,distribution=raring,flavor=armhf/33//artifact/results/coverity/NO_COVERITY_DEFECTS.txt
    http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/./build=pbuilder,distribution=raring,flavor=i386/33//artifact/results/coverity/NO_COVERITY_DEFECTS.txt

Click here to trigger a rebuild:
http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/33//rebuild/?

review: Approve (continuous-integration)
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Approve. Indeed the GFile object is no longer used once the monitor is created.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches