Merge ~cjwatson/launchpad:opt-in-zopeless-immediate-mail into launchpad:master

Proposed by Colin Watson
Status: Needs review
Proposed branch: ~cjwatson/launchpad:opt-in-zopeless-immediate-mail
Merge into: launchpad:master
Diff against target: 399 lines (+63/-41)
14 files modified
daemons/buildd-manager.tac (+1/-5)
lib/lp/bugs/scripts/bugnotification.py (+11/-2)
lib/lp/bugs/scripts/tests/test_bugnotification.py (+1/-1)
lib/lp/bugs/tests/bugs-emailinterface.txt (+6/-11)
lib/lp/code/mail/codehandler.py (+1/-1)
lib/lp/services/job/celeryjob.py (+0/-2)
lib/lp/services/job/runner.py (+7/-6)
lib/lp/services/mail/basemailer.py (+7/-2)
lib/lp/services/mail/sendmail.py (+12/-0)
lib/lp/services/mail/tests/incomingmail.txt (+6/-2)
lib/lp/services/mail/tests/test_incoming.py (+4/-0)
lib/lp/services/scripts/base.py (+0/-5)
lib/lp/testing/layers.py (+0/-4)
scripts/mlist-import.py (+7/-0)
Reviewer Review Type Date Requested Status
Launchpad code reviewers Pending
Review via email: mp+373727@code.qastaging.launchpad.net

Commit message

Mostly disable Zopeless immediate mail delivery

BaseMailer, job OOPS/error notifications, and a few other places still
need it.

This is a step towards being able to disable it across the board so that
we can avoid ever having situations where operation/mail/operation/mail
sequences send duplicate mail if a non-first operation fails and has to
be retried. There are still several things that need to be fixed,
notably archiveuploader; but this branch at least means that it's
disabled for tests by default, which will simplify the process of fixing
archiveuploader.

Description of the change

This is essentially the same as https://code.launchpad.net/~cjwatson/launchpad/opt-in-zopeless-immediate-mail/+merge/270383, converted to git and rebased on master.

To post a comment you must log in.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: