Merge ~cjwatson/launchpad:login-interstitial into launchpad:master
Proposed by
Colin Watson
| Status: | Needs review |
|---|---|
| Proposed branch: | ~cjwatson/launchpad:login-interstitial |
| Merge into: | launchpad:master |
| Diff against target: |
1078 lines (+534/-110) 10 files modified
lib/lp/app/browser/configure.zcml (+12/-0) lib/lp/app/browser/launchpad.py (+3/-1) lib/lp/services/webapp/login.py (+208/-41) lib/lp/services/webapp/templates/login-new-account.pt (+36/-0) lib/lp/services/webapp/templates/login-reactivate-account.pt (+43/-0) lib/lp/services/webapp/tests/test_login.py (+153/-25) lib/lp/testopenid/browser/server.py (+37/-25) lib/lp/testopenid/interfaces/server.py (+7/-2) lib/lp/testopenid/stories/logging-in.txt (+1/-0) utilities/make-lp-user (+34/-16) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Launchpad code reviewers | Pending | ||
|
Review via email:
|
|||
Commit message
Add interstitial pages when creating or reactivating an account
Description of the change
These provide an opportunity to present the user with the terms of service and privacy policy and require that they explicitly accept them, as well as making it harder to reactivate an account by accident.
To support testing this locally, I extended make-lp-user to be able to create placeholder accounts, and adjusted testopenid so that it can authenticate as an inactive account by explicitly supplying the username.
This is essentially the same as https:/
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
