Merge ~cjwatson/launchpad:built-using-guard-deletion into launchpad:master

Proposed by Colin Watson
Status: Needs review
Proposed branch: ~cjwatson/launchpad:built-using-guard-deletion
Merge into: launchpad:master
Prerequisite: ~cjwatson/launchpad:built-using-ui
Diff against target: 393 lines (+293/-1)
5 files modified
lib/lp/soyuz/interfaces/binarysourcereference.py (+15/-0)
lib/lp/soyuz/model/binarysourcereference.py (+29/-1)
lib/lp/soyuz/model/publishing.py (+54/-0)
lib/lp/soyuz/tests/test_binarysourcereference.py (+100/-0)
lib/lp/soyuz/tests/test_publishing.py (+95/-0)
Reviewer Review Type Date Requested Status
Launchpad code reviewers Pending
Review via email: mp+381239@code.qastaging.launchpad.net

Commit message

Guard removal of sources referenced by Built-Using

Description of the change

Prevent SourcePackagePublishingHistory.requestDeletion from deleting source publications that have Built-Using references from active binary publications in the same archive and suite.

This isn't necessarily complete: in particular, it can miss references from other pockets, and in any case it might race with a build still in progress. The intent of this is not to ensure integrity, but to avoid some easily-detectable mistakes that could cause confusion.

To post a comment you must log in.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: