Launchpad itself

Merge ~cjwatson/launchpad:fix-miscompiled-pofile-query into launchpad:master

Proposed by Colin Watson on 2021-01-07

Status:

Merged

Approved by:

Colin Watson on 2021-01-07

Approved revision:

49064791591257da0a00980472d12e8f5cf21ad4

Merge reported by:

Otto Co-Pilot

Merged at revision:

not available

Proposed branch:

~cjwatson/launchpad:fix-miscompiled-pofile-query

Merge into:

launchpad:master

Diff against target:

20 lines (+2/-2)

1 file modified

lib/lp/translations/model/pofile.py (+2/-2)

Related bugs:

Bug #736005: POFile:+translate timeouts

Critical

Triaged

Link a bug report

Reviewer	Review Type	Date Requested	Status
Thiago F. Pappacena (community)		2021-01-07	Approve on 2021-01-07
Review via email: mp+395934@code.qastaging.launchpad.net

Commit message

Fix miscompiled query in POFileMixin._getTranslationSearchQuery

Description of the change

Converting POFile queries to Storm (https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/394702) introduced a serious performance regression. It turns out that using Reference objects via ClassAlias doesn't work as expected. The following:

tm_ids = ClassAlias(TranslationMessage, "tm_ids")
tm_ids.language == pofile.language

... is compiled to "TranslationMessage.language = $ID" rather than "tm_ids.language = $ID". Using the Reference's Int partner instead works around this.

I haven't worked out how to test this automatically (or even whether it results in a different set of rows rather than merely a much slower query), but I've manually tested on staging that the modified query performs reasonably again.

Revision history for this message