Launchpad itself

Merge ~cjwatson/launchpad:zcml-namespaces-mail into launchpad:master

  1. Git
  2. lp:~cjwatson/launchpad
  3. zcml-namespaces-mail
  4. Merge into master
Proposed by Colin Watson
Status: Needs review
Proposed branch: ~cjwatson/launchpad:zcml-namespaces-mail
Merge into: launchpad:master
Diff against target: 242 lines (+56/-23)
6 files modified
configs/development/directory-testing-mailbox.zcml.example (+3/-3)
doc/reference/email.rst (+11/-10)
lib/lp/services/mail/doc/mailbox.rst (+2/-2)
lib/lp/services/mail/meta.zcml (+35/-5)
zcml/package-includes/mail-configure-normal.zcml (+2/-1)
zcml/package-includes/mail-configure-testing.zcml (+3/-2)
Reviewer Review Type Date Requested Status
Guruprasad Approve
Review via email: mp+437576@code.qastaging.launchpad.net

Commit message

Move ZCML mail-related directives to lp namespace

Description of the change

As with commit 57196c1d6a220f00039e027768cc05368135f556, it makes sense to move our various local `*MailBox` and `*Mailer` directives to our own namespace rather than poking them into the Zope mail namespace.

We retain some backward-compatibility registrations with the old namespace for the time being, as these directives appear in some per-environment configuration files.

To post a comment you must log in.
Revision history for this message
Guruprasad (lgp171188) wrote :

LGTM 👍 With these changes, https://git.launchpad.net/launchpad/tree/charm/launchpad-scripts/templates/inbound-email-configure.zcml.j2 should also be updated right?

review: Approve
Reply

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: