Merge lp://qastaging/~cjwatson/launchpad/custom-same-archive into lp://qastaging/launchpad
Proposed by
Colin Watson
| Status: | Merged |
|---|---|
| Approved by: | Curtis Hovey |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 16176 |
| Proposed branch: | lp://qastaging/~cjwatson/launchpad/custom-same-archive |
| Merge into: | lp://qastaging/launchpad |
| Diff against target: |
179 lines (+46/-47) 2 files modified
lib/lp/soyuz/scripts/custom_uploads_copier.py (+5/-4) lib/lp/soyuz/scripts/tests/test_custom_uploads_copier.py (+41/-43) |
| To merge this branch: | bzr merge lp://qastaging/~cjwatson/launchpad/custom-same-archive |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Curtis Hovey (community) | code | Approve | |
|
Review via email:
|
|||
Commit message
Automatically approve copies of UEFI custom uploads within the same archive.
Description of the change
== Summary ==
Bug 1068558: UEFI copies within the same archive shouldn't require re-approval. This is a minor inconvenience, but it would be nice to fix it.
== Proposed fix ==
If the source and target archives match, automatically approve the copy.
== Implementation details ==
I re-expressed some tests slightly to save LoC, mostly just by removing repetition of the form "foo_upload.
== Tests ==
bin/test -vvct test_custom_
== Demo and Q/A ==
Copy efilinux from quantal to quantal-proposed on dogfood. It should not require manual approval.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thank you.