Launchpad itself

Merge lp://qastaging/~cjwatson/launchpad/improve-dpkg-architecture-cache into lp://qastaging/launchpad

  1. improve-dpkg-architecture-cache
  2. Merge into devel
Proposed by Colin Watson
Status: Merged
Merged at revision: 18494
Proposed branch: lp://qastaging/~cjwatson/launchpad/improve-dpkg-architecture-cache
Merge into: lp://qastaging/launchpad
Diff against target: 123 lines (+55/-6)
2 files modified
lib/lp/soyuz/adapters/buildarch.py (+10/-5)
lib/lp/soyuz/adapters/tests/test_buildarch.py (+45/-1)
To merge this branch: bzr merge lp://qastaging/~cjwatson/launchpad/improve-dpkg-architecture-cache
Reviewer Review Type Date Requested Status
William Grant code Approve
Review via email: mp+332853@code.qastaging.launchpad.net

Commit message

Improve DpkgArchitectureCache's timeline handling, and speed it up a bit in some cases.

Description of the change

We can only really do so much to make this faster without https://bugs.debian.org/771058, but the nested list comprehension I wrote five years was very confusing for 2017-me to read, so I took the opportunity to make it short-circuit properly once any wildcard has matched for a given architecture.

To post a comment you must log in.
Revision history for this message
William Grant (wgrant) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.