Merge lp://qastaging/~cjwatson/launchpad/snap-upload-check-filename into lp://qastaging/launchpad
Proposed by
Colin Watson
| Status: | Merged |
|---|---|
| Merged at revision: | 18187 |
| Proposed branch: | lp://qastaging/~cjwatson/launchpad/snap-upload-check-filename |
| Merge into: | lp://qastaging/launchpad |
| Diff against target: |
86 lines (+31/-10) 2 files modified
lib/lp/archiveuploader/snapupload.py (+13/-9) lib/lp/archiveuploader/tests/test_snapupload.py (+18/-1) |
| To merge this branch: | bzr merge lp://qastaging/~cjwatson/launchpad/snap-upload-check-filename |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| William Grant | code | Approve | |
|
Review via email:
|
|||
Commit message
If other files (e.g. manifests) are uploaded alongside snaps, make sure that there is still at least one snap.
Description of the change
If other files (e.g. manifests) are uploaded alongside snaps, make sure that there is still at least one snap.
To post a comment you must log in.
Revision history for this message
| Maximiliano Bertacchini (maxiberta) wrote | # |
Revision history for this message
| William Grant (wgrant) | # |
review:
Approve
(code)
Revision history for this message
| Colin Watson (cjwatson) | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good. One question inline.