Merge lp://qastaging/~cjwatson/snapcraft/apt-get-y into lp://qastaging/~snappy-dev/snapcraft/core

Proposed by Colin Watson
Status: Merged
Approved by: Michael Terry
Approved revision: 85
Merged at revision: 86
Proposed branch: lp://qastaging/~cjwatson/snapcraft/apt-get-y
Merge into: lp://qastaging/~snappy-dev/snapcraft/core
Diff against target: 12 lines (+1/-1)
1 file modified
snapcraft/cmds.py (+1/-1)
To merge this branch: bzr merge lp://qastaging/~cjwatson/snapcraft/apt-get-y
Reviewer Review Type Date Requested Status
Michael Terry (community) Approve
Review via email: mp+265003@code.qastaging.launchpad.net

Commit message

Call apt-get install with -y to avoid a silent prompt.

Description of the change

Call apt-get install with -y to avoid a silent prompt.

Without this, apt-get may wait for input on stdin without any indication that it's doing so (due to stdout being redirected to /dev/null). In any case, this is needed to run snapcraft non-interactively, such as from a Launchpad builder.

To post a comment you must log in.
Revision history for this message
Michael Terry (mterry) wrote :

Awesome, thanks! :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches