Merge lp://qastaging/~ckamphaus/pasaffe/pasaffe into lp://qastaging/~mdeslaur/pasaffe/trunk

Proposed by Christophe Kamphaus
Status: Merged
Merged at revision: 714
Proposed branch: lp://qastaging/~ckamphaus/pasaffe/pasaffe
Merge into: lp://qastaging/~mdeslaur/pasaffe/trunk
Diff against target: 1059 lines (+477/-372)
5 files modified
NEWS (+27/-5)
data/ui/PasaffeWindow.ui (+32/-30)
pasaffe/PasaffeWindow.py (+92/-12)
po/pasaffe.pot (+325/-324)
setup.py (+1/-1)
To merge this branch: bzr merge lp://qastaging/~ckamphaus/pasaffe/pasaffe
Reviewer Review Type Date Requested Status
Marc Deslauriers Approve
Review via email: mp+373060@code.qastaging.launchpad.net

Description of the change

 * Enhancements:
   - Double click on tree item toggles folder expanded state or copies password.
   - On enter, toggles folder expanded state or opens password entry for edit.
   - Navigate tree with left & right key presses: toggling expanded state or going to parent / child.
   - Show copy menu items first in the tree item context menu
   - Display username in the tree view item title

 * Bug fixes:
   - Fix copy truncates password containing pound sign (LP: #1819141)

To post a comment you must log in.
Revision history for this message
Christophe Kamphaus (ckamphaus) wrote :

Since I wasn't sure how long the review process and releasing a new version would take, I created a ppa where I could release new versions from my branch:
https://launchpad.net/~ckamphaus/+archive/ubuntu/pasaffe

728. By Christophe Kamphaus

Clear clipboard when locking or closing the window.
Do not clear the clipboard if the user has copied
something in another program.

729. By Christophe Kamphaus

Added the clipboard clearing feature to the NEWS

Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

Changes look good. Thanks!

review: Approve
Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

> Double click on tree item toggles folder expanded state or copies password

I'm really not sure about this one...it's odd to me that double clicking an entry would copy the password instead of opening it, and would probably be surprising to most users. This change I may revert, I'll have to think about it.

> Display username in the tree view item title

I think I'll add an option to turn this on. I don't see the use case for it unless you have multiple accounts on the same system, and adding the username clutters the tree.

Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

> Double click on tree item toggles folder expanded state or copies password

So, I am going to add a new option in the preferences for this one too:

Double-Click [edits entry][copies password]

Revision history for this message
Christophe Kamphaus (ckamphaus) wrote :

The reason for most of my changes is that I'm using pasaffe at work and I like my workflows to be as efficient as possible.

E.g. I have some server environments where I have multiple user accounts thus it's very important that I can directly select the right entry without having to go through all of them until I find the one with the right username.
The re-ordering of the context menu and the copy through double-click make it quicker to copy a password. (I notice that copying a password is something I do a lot more often than editing one)
Similarly the additional possibility of using the left and right keys to traverse the tree and collapse/expand folders make it easier to find entries in a big safe.
Finally the clipboard clearing improves the security when exiting pasaffe directly after copying a password. Also the existing clearing of the clipboard through a timer is improved since it does not clear the clipboard if the user has copied something in another program after the password.

I am glad my changes helped improve pasaffe and that you will make the username appearance in the entry title and double-click behavior configurable.

Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

Thanks for the improvements! :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches