Charm Helpers

Merge lp://qastaging/~cmars/charm-helpers/add-metricenv into lp://qastaging/charm-helpers

  1. add-metricenv
  2. Merge into devel
Proposed by Casey Marshall
Status: Merged
Merged at revision: 679
Proposed branch: lp://qastaging/~cmars/charm-helpers/add-metricenv
Merge into: lp://qastaging/charm-helpers
Diff against target: 74 lines (+59/-0)
2 files modified
charmhelpers/core/hookenv.py (+31/-0)
tests/core/test_hookenv.py (+28/-0)
To merge this branch: bzr merge lp://qastaging/~cmars/charm-helpers/add-metricenv
Reviewer Review Type Date Requested Status
Marco Ceppi Approve
Chris Holcombe (community) Needs Fixing
Review via email: mp+315952@code.qastaging.launchpad.net

Description of the change

Add functions to charmhelpers.core.hookenv related to Juju Metrics (https://jujucharms.com/docs/stable/developer-metrics).

To post a comment you must log in.
lp://qastaging/~cmars/charm-helpers/add-metricenv updated
679. By Casey Marshall

Add metrics functions to charmhelpers.core.hookenv.

Revision history for this message
Chris Holcombe (xfactor973) wrote :

Other than a little nit this looks ok to me.

review: Needs Fixing
Revision history for this message
Chris Holcombe (xfactor973) :
lp://qastaging/~cmars/charm-helpers/add-metricenv updated
680. By Casey Marshall

Catch EnvironmentError exception, covers subclasses such as IOError and OSError.

Revision history for this message
Casey Marshall (cmars) wrote :

Updated, PTAL

Revision history for this message
Marco Ceppi (marcoceppi) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches