Merge lp://qastaging/~cmiller/desktopcouch/abstract-wrappers into lp://qastaging/desktopcouch
Proposed by
Chad Miller
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Chad Miller | ||||
| Approved revision: | 180 | ||||
| Merged at revision: | 179 | ||||
| Proposed branch: | lp://qastaging/~cmiller/desktopcouch/abstract-wrappers | ||||
| Merge into: | lp://qastaging/desktopcouch | ||||
| Diff against target: |
47 lines (+19/-0) 2 files modified
desktopcouch/records/server_base.py (+3/-0) desktopcouch/records/tests/test_server.py (+16/-0) |
||||
| To merge this branch: | bzr merge lp://qastaging/~cmiller/desktopcouch/abstract-wrappers | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Eric Casteleijn (community) | Approve | ||
| Vincenzo Di Somma (community) | Approve | ||
|
Review via email:
|
|||
Commit message
The view wrapper that assists with reconnecting did not implement attributes that some clients (like Lernid) use. Now, catch any attribute access on the wrapper and pass it through to the proxied object. This should make the proxy object functionally identical to the destination object. (LP: #652095)
To post a comment you must log in.
Revision history for this message
| Vincenzo Di Somma (vds) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Code looks good, tests pass.