desktopcouch

Merge lp://qastaging/~cmiller/desktopcouch/check-http-status-on-api into lp://qastaging/desktopcouch

  1. check-http-status-on-api
  2. Merge into trunk
Proposed by Chad Miller
Status: Merged
Approved by: Chad Miller
Approved revision: 265
Merged at revision: 265
Proposed branch: lp://qastaging/~cmiller/desktopcouch/check-http-status-on-api
Merge into: lp://qastaging/desktopcouch
Diff against target: 43 lines (+14/-13)
1 file modified
desktopcouch/application/replication_services/ubuntuone.py (+14/-13)
To merge this branch: bzr merge lp://qastaging/~cmiller/desktopcouch/check-http-status-on-api
Reviewer Review Type Date Requested Status
Eric Casteleijn (community) Approve
Natalia Bidart (community) Approve
Review via email: mp+48266@code.qastaging.launchpad.net

Commit message

Use urllib2, which seperates reading response code from reading content, instead of httplib2, which doesn't. httplib(2) insists that the Content-Length header match the actual length, and Ubuntu One's middleware may change the content in transit. (LP: #711208)

To post a comment you must log in.
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

I'm getting this traces while running the tests:

Traceback (most recent call last):
  File "/home/nessita/canonical/desktopcouch/review_check-http-status-on-api/desktopcouch/application/plugins/ubuntuone_pairing.py", line 90, in listen_to_dbus
    dbus_interface=iface)
  File "/usr/lib/pymodules/python2.6/dbus/bus.py", line 151, in add_signal_receiver
    path, **keywords)
  File "/usr/lib/pymodules/python2.6/dbus/connection.py", line 382, in add_signal_receiver
    self._require_main_loop()
RuntimeError: To make asynchronous calls, receive signals or export objects, D-Bus connections must be attached to a main loop by passing mainloop=... to the constructor or calling dbus.set_default_main_loop(...)

Revision history for this message
Natalia Bidart (nataliabidart) :
review: Approve
Revision history for this message
Eric Casteleijn (thisfred) wrote :

kewl

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches