desktopcouch

Merge lp://qastaging/~cmiller/desktopcouch/code-split-changes-relative-path-to-configs into lp://qastaging/desktopcouch

Proposed by Chad Miller on 2010-11-22

Status:

Merged

Approved by:

dobey on 2010-11-23

Approved revision:

221

Merged at revision:

221

Proposed branch:

Merge into:

Diff against target:

2 files modified

desktopcouch/application/start_local_couchdb.py (+13/-14)
desktopcouch/application/tests/test_local_files.py (+11/-0)

To merge this branch:

bzr merge lp://qastaging/~cmiller/desktopcouch/code-split-changes-relative-path-to-configs

Medium

Fix Released

Link a bug report

Reviewer	Date Requested	Status
dobey (community)		Approve on 2010-11-23
Eric Casteleijn (community)	2010-11-22	Approve on 2010-11-22
Review via email: mp+41515@code.qastaging.launchpad.net

Fix a problem with splitting code into packages. The relative path to config directories was no longer valid.

Revision history for this message

Eric Casteleijn (thisfred) wrote on 2010-11-22:

Awesome job, looks good.

line 193 in start_local_couchdb.py is too long now, if you fix that +1

review: Approve

Revision history for this message

dobey (dobey) wrote on 2010-11-23:

The path string should be built with os.path.join() so that it also works correctly on other platforms that don't use / as the separator character.

review: Needs Fixing

219. By Chad Miller on 2010-11-23: Use OS-independent functions to locate files.
220. By Chad Miller on 2010-11-23: Fix minor lint complaint about exception instance names.
221. By Chad Miller on 2010-11-23: Remove debugging statement.