desktopcouch

Merge lp://qastaging/~cmiller/desktopcouch/dc-expire-logs into lp://qastaging/desktopcouch

  1. dc-expire-logs
  2. Merge into trunk
Proposed by Chad Miller
Status: Merged
Approved by: Natalia Bidart
Approved revision: 142
Merged at revision: not available
Proposed branch: lp://qastaging/~cmiller/desktopcouch/dc-expire-logs
Merge into: lp://qastaging/desktopcouch
Diff against target: 60 lines (+18/-3)
2 files modified
desktopcouch/local_files.py (+16/-1)
desktopcouch/start_local_couchdb.py (+2/-2)
To merge this branch: bzr merge lp://qastaging/~cmiller/desktopcouch/dc-expire-logs
Reviewer Review Type Date Requested Status
Natalia Bidart (community) Approve
Joshua Blount (community) Approve
Review via email: mp+21677@code.qastaging.launchpad.net

Commit message

Log files can grow large. Expire old ones when we start up and start fresh.

To post a comment you must log in.
Revision history for this message
Joshua Blount (jblount) wrote :

This looks perfectly sensible.

review: Approve
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

For clarity sake I think ti would be best to tweak this:

    for src_ext, dst_ext in ("23", "12", (None, "1")):

to this:

    for src_ext, dst_ext in ((2, 3), (1, 2), (None, 1)):

Other than that, it looks correct.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches